Skip to content

Remove library versions from nav title#994

Open
tannerlinsley wants to merge 1 commit into
mainfrom
taren/remove-nav-version-suffix
Open

Remove library versions from nav title#994
tannerlinsley wants to merge 1 commit into
mainfrom
taren/remove-nav-version-suffix

Conversation

@tannerlinsley

@tannerlinsley tannerlinsley commented Jun 16, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Summary

  • remove resolved library version text from the navbar title
  • keep the library name/title in place after the TanStack logo

Tests

  • pnpm test

Summary by CodeRabbit

  • Refactoring
    • Simplified the library title display logic, removing version parameter handling to streamline the user interface while maintaining the core library name display.

@coderabbitai

coderabbitai Bot commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 99a29624-23f6-4eee-a3bf-3e72de1f27cb

📥 Commits

Reviewing files that changed from the base of the PR and between f8c0de3 and a01ebc8.

📒 Files selected for processing (1)
  • src/routes/_library/$libraryId/route.tsx
📝 Walkthrough

Walkthrough

In src/routes/_library/$libraryId/route.tsx, the staticData.Title component is simplified to use Route.useParams() instead of useParams, derive only libraryId, and render a Link containing solely the gradient library name. Version param resolution and its associated display spans are removed, along with the useParams import.

Changes

Library Route Title Simplification

Layer / File(s) Summary
Simplify staticData.Title rendering
src/routes/_library/$libraryId/route.tsx		 Removes useParams import; switches to Route.useParams() for libraryId; strips version param lookup and version display spans, leaving only the gradient library name in the Link.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • TanStack/tanstack.com#982: Also removes $version/version-driven title rendering from library navigation components, directly related to this PR's version display removal in the route title.

Poem

A rabbit hopped through tangled code one day,
And found a version label in the way.
"This span's not needed," said the bunny bright,
Snipped out the params, kept the gradient light.
Now library names gleam clean and fair — hooray! 🐇✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: removing library versions from the navigation title, which aligns with the actual code modifications that removed version-handling behavior.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch taren/remove-nav-version-suffix

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tannerlinsley